Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: verify commitment proofs as secp256k1 signatures #8

Merged
merged 11 commits into from
Jan 28, 2025
Merged

feat: verify commitment proofs as secp256k1 signatures #8

merged 11 commits into from
Jan 28, 2025

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented Jan 24, 2025 •
edited
Loading

Needed for informalsystems/ibc-starknet#229

@rnbguy rnbguy requested a review from Farhad-Shabani January 24, 2025 17:06
Farhad-Shabani
Farhad-Shabani reviewed Jan 24, 2025
View reviewed changes
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as a temporary solution. Just asked two questions.

I’d also recommend adding the relevant logic on the relayer side and testing it out before wrapping things up with this issue.

ibc-clients/cw-context/src/handlers.rs Show resolved Hide resolved
ibc-clients/cw-context/src/types/msgs.rs Show resolved Hide resolved
ibc-clients/cw-context/src/types/msgs.rs Show resolved Hide resolved
@rnbguy rnbguy force-pushed the rano/commitment-proof-as-signature branch from 4d21865 to afcfdd0 Compare January 27, 2025 10:27
@rnbguy rnbguy force-pushed the rano/commitment-proof-as-signature branch from 73565bf to 6be76b0 Compare January 27, 2025 13:34
@rnbguy rnbguy requested a review from Farhad-Shabani January 27, 2025 14:02
@rnbguy rnbguy mentioned this pull request Jan 27, 2025
Open
@rnbguy rnbguy merged commit 7d37df4 into starknet/demo2 Jan 28, 2025
7 checks passed
@rnbguy rnbguy deleted the rano/commitment-proof-as-signature branch January 28, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Farhad-Shabani Farhad-Shabani Awaiting requested review from Farhad-Shabani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnbguy @Farhad-Shabani